Skip to content

πŸ›‘οΈ Sentinel: [HIGH] XSS 취약점 μˆ˜μ • 및 URL 인코딩 버그 ν•΄κ²° - #61

Closed
seonghobae wants to merge 1 commit into
masterfrom
sentinel-fix-xss-urlencode-3905599889944578562
Closed

πŸ›‘οΈ Sentinel: [HIGH] XSS 취약점 μˆ˜μ • 및 URL 인코딩 버그 ν•΄κ²°#61
seonghobae wants to merge 1 commit into
masterfrom
sentinel-fix-xss-urlencode-3905599889944578562

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

🚨 Severity: HIGH
πŸ’‘ Vulnerability: 파일 및 디렉토리 이름을 HTML ν…œν”Œλ¦Ώμ— 직접 μ‚½μž…ν•˜μ—¬ 크둜슀 μ‚¬μ΄νŠΈ μŠ€ν¬λ¦½νŒ…(XSS) 취약점 λ°œμƒ. 띄어쓰기가 ν¬ν•¨λœ 파일 μ΄λ¦„μ˜ 경우 href 속성이 κΉ¨μ§€λŠ” 문제 λ™λ°˜.
🎯 Impact: μ•…μ˜μ μΈ 파일 λ˜λŠ” 디렉토리 이름을 κ°€μ§„ νŒŒμΌμ„ 이 λ„κ΅¬λ‘œ 인덱싱할 경우, μ‚¬μš©μžκ°€ ν•΄λ‹Ή index.html νŒŒμΌμ„ μ—΄λžŒν•  λ•Œ μž„μ˜μ˜ μŠ€ν¬λ¦½νŠΈκ°€ μ‹€ν–‰λ˜μ–΄ λ³΄μ•ˆ λ¬Έμ œκ°€ λ°œμƒν•  수 있음.
πŸ”§ Fix: String.escapeHtml() 및 String.encodeUrlPath() Kotlin ν™•μž₯ ν•¨μˆ˜λ₯Ό μΆ”κ°€ν•˜κ³  ν…œν”Œλ¦Ώ λ³€μˆ˜μ— μ μš©ν•˜μ—¬ 파일 이름 λ¬Έμžμ—΄μ„ μ•ˆμ „ν•˜κ²Œ μ΄μŠ€μΌ€μ΄ν”„(HTML Entity μΉ˜ν™˜)ν•˜κ³  URL 인코딩 처리.
βœ… Verification: JUnit ν…ŒμŠ€νŠΈμ™€ Jacocoλ₯Ό 톡해 100% λͺ…λ Ήμ–΄ 컀버리지λ₯Ό λ‹¬μ„±ν•˜μ—¬ ν…ŒμŠ€νŠΈ 톡과 μ™„λ£Œ.

  • pre_commit_instructions에 따라 .jules/sentinel.md 기둝 및 Code Review 100% 톡과 μ™„λ£Œ.

PR created automatically by Jules for task 3905599889944578562 started by @seonghobae

- `escapeHtml` 및 `encodeUrlPath` ν™•μž₯ ν•¨μˆ˜ μΆ”κ°€
- `process_dir` λ‚΄ HTML λ Œλ”λ§ μ‹œ 디렉토리 및 파일λͺ…에 μ΄μŠ€μΌ€μ΄ν”„ 및 URL 인코딩 적용
- Jacoco μ„€μ • 및 λͺ…λ Ήμ–΄ 컀버리지 100% ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by already-merged XSS and URL-encoding hardening (#21 and #45). Current master escapes HTML including backticks, quotes attributes, percent-encodes href path segments, and adds CSP defense-in-depth.

@seonghobae seonghobae closed this Jun 30, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by already-merged XSS and URL-encoding hardening (#21 and #45). Current master escapes HTML including backticks, quotes attributes, percent-encodes href path segments, and adds CSP defense-in-depth.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant